New rule to detect if a sheet has @import over 31 sheets in IE6-9 #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pomeh - Agree. Thanks for the feedback. I will update the code and submit another patch. |
Member
|
@dashk: can you fetch, rebase and squash the patches? |
dashk
force-pushed
the
master
branch
2 times, most recently
from
50ea8a7 to
677555b
Compare
Contributor
Author
|
Sorry about the delay @XhmikosR! It's been rebased & squashed. |
XhmikosR
added a commit
that referenced
this pull request
Jan 18, 2016
New rule to detect if a sheet has @import over 31 sheets in IE6-9
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rule to detect if a sheet has
@importover 31 sheets in IE6-9.While
@importis technically OK in IE6-9, there is a hard limit you can@importper sheet. This is documented on MSDN [1].This rule should only apply to IE6 to IE9.
A rule page [2] has been created to document this optional rule. If accepted, this page should be added to Compatibility section in Rules.
[1] http://blogs.msdn.com/b/ieinternals/archive/2011/05/14/internet-explorer-stylesheet-rule-selector-import-sheet-limit-maximum.aspx
[2] https://github.com/dashk/csslint/wiki/Disallow-a-sheet-@import---31-sheets-in-IE6-9